Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix graph breaks in Mixtral (#65) #1705

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Fix graph breaks in Mixtral (#65) #1705

merged 1 commit into from
Feb 5, 2025
+19 −21

Conversation

ShengYang1
Copy link

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@ShengYang1 ShengYang1 requested a review from regisss as a code owner January 20, 2025 01:53
@emascarenhas
Copy link
Contributor

@ShengYang1 , Please do a "make style" check and confirm no errors.
Also run the pytest related to Mixtral to make sure they continue to pass.

@emascarenhas
Copy link
Contributor

@ShengYang1 , Please do a "make style" check and confirm no errors. Also run the pytest related to Mixtral to make sure they continue to pass.

Any update?

mlapinskix
mlapinskix approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@mlapinskix mlapinskix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pi314ever added a commit to pi314ever/optimum-habana that referenced this pull request Feb 4, 2025
@pi314ever
Apply fixes from huggingface#1705
0a0cefb 
Signed-off-by: Daniel Huang <[email protected]>
@libinta libinta added synapse1.20 run-test Run CI for PRs from external contributors labels Feb 5, 2025
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss regisss changed the base branch from main to synapse_1_20 February 5, 2025 11:10
regisss
regisss approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@regisss regisss merged commit 6a520ff into huggingface:synapse_1_20 Feb 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisss regisss regisss approved these changes

@mlapinskix mlapinskix mlapinskix approved these changes

Assignees
No one assigned
Labels
run-test Run CI for PRs from external contributors synapse1.20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ShengYang1 @emascarenhas @HuggingFaceDocBuilderDev @regisss @mlapinskix @libinta